Merge pull request 'chore(deps): update dependency com.android.tools.build:gradle to v8.4.0' (#24) from renovate/com.android.tools.build-gradle-8.x into master

Reviewed-on: #24

.gitea/workflows/apk.yml

@@ -1,25 +1,21 @@
 name: apk
-on: [push]
+on: [ push ]
 
 jobs:
   build:
     runs-on: ubuntu-latest
     container: mingc/android-build-box
     steps:
-      - uses: actions/setup-go@v3
-        with:
-          go-version: '>=1.20.1'
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - run: curl -sSL -u "$USERNAME:$PASSWORD" -o ShareWithTitle/$STORE_FILE https://cloud.crystalyx.net/remote.php/dav/files/$USERNAME/Bordel/$STORE_FILE
-      - run: sh gradlew build bundleRelease assembleRelease --no-daemon
-      - uses: https://gitea.com/actions/release-action@main
-        if: startsWith(gitea.ref, 'refs/tags')
+      - run: sh gradlew lint build bundle assemble --no-daemon
+      - uses: akkuman/gitea-release-action@v1
+        if: gitea.ref_type == 'tag'
         with:
           files: |
             ShareWithTitle/build/outputs/apk/debug/ShareWithTitle-debug.apk
             ShareWithTitle/build/outputs/apk/release/ShareWithTitle-release.apk
             ShareWithTitle/build/outputs/bundle/release/ShareWithTitle-release.aab
-          api_key: ${{ secrets.RELEASE_TOKEN }}
     env:
       USERNAME: ${{ secrets.USERNAME }}
       PASSWORD: ${{ secrets.PASSWORD }}

POLICY.md

@@ -0,0 +1,39 @@
+**Privacy Policy**
+
+I built the Share with title app as an Open Source app. This is provided by me at no cost and is intended for use as is.
+
+This page is used to inform visitors regarding my policies with the collection, use, and disclosure of Personal Information if anyone decided to use my app.
+
+If you choose to use my app, then you agree to the collection and use of information in relation to this policy. The Personal Information that I collect is used for providing and improving the app. I will not use or share your information with anyone except as described in this Privacy Policy.
+
+The terms used in this Privacy Policy have the same meanings as in our Terms and Conditions, which are accessible at Share with title unless otherwise defined in this Privacy Policy.
+
+**Information Collection and Use**
+
+For a better experience, while using our app, I may require you to provide us with certain personally identifiable information. The information that I request will be retained on your device and is not collected by me in any way.
+
+**Log Data**
+
+I want to inform you that whenever you use my app, in a case of an error in the app I collect data and information (through third-party products) on your phone called Log Data. This Log Data may include information such as your device Internet Protocol (“IP”) address, device name, operating system version, the configuration of the app when utilizing my app, the time and date of your use of the app, and other statistics.
+
+**Security**
+
+I value your trust in providing us your Personal Information, thus we are striving to use commercially acceptable means of protecting it. But remember that no method of transmission over the internet, or method of electronic storage is 100% secure and reliable, and I cannot guarantee its absolute security.
+
+**Links to Other Sites**
+
+This app may contain links to other sites. If you click on a third-party link, you will be directed to that site. Note that these external sites are not operated by me. Therefore, I strongly advise you to review the Privacy Policy of these websites. I have no control over and assume no responsibility for the content, privacy policies, or practices of any third-party sites or services.
+
+**Children’s Privacy**
+
+I do not knowingly collect personally identifiable information from children. I encourage all children to never submit any personally identifiable information through the Application and/or Services. I encourage parents and legal guardians to monitor their children's Internet usage and to help enforce this Policy by instructing their children never to provide personally identifiable information through the Application and/or Services without their permission. If you have reason to believe that a child has provided personally identifiable information to us through the Application and/or Services, please contact us. You must also be at least 16 years of age to consent to the processing of your personally identifiable information in your country (in some countries we may allow your parent or guardian to do so on your behalf).
+
+**Changes to This Privacy Policy**
+
+I may update our Privacy Policy from time to time. Thus, you are advised to review this page periodically for any changes. I will notify you of any changes by posting the new Privacy Policy on this page.
+
+This policy is effective as of 2024-02-28
+
+**Contact Us**
+
+If you have any questions or suggestions about my Privacy Policy, do not hesitate to contact me at https://blog.crystalyx.net/contact/.

ShareWithTitle/build.gradle

@@ -2,13 +2,13 @@ apply plugin: 'com.android.application'
 
 android {
     namespace 'net.crystalyx.sharewithtitle'
-    compileSdk 33
+    compileSdk 34
     defaultConfig {
         applicationId "net.crystalyx.sharewithtitle"
         minSdkVersion 11
-        targetSdkVersion 33
-        versionCode 4
-        versionName "1.3"
+        targetSdkVersion 34
+        versionCode 9
+        versionName "1.7"
     }
     signingConfigs {
         release {
@@ -32,5 +32,5 @@ android {
 }
 
 dependencies {
-    implementation 'org.jsoup:jsoup:1.16.1'
+    implementation 'org.jsoup:jsoup:1.17.2'
 }

ShareWithTitle/src/main/AndroidManifest.xml

@@ -1,4 +1,5 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
+
     <uses-permission android:name="android.permission.INTERNET" />
     <application
         android:icon="@mipmap/ic_launcher"
@@ -14,4 +15,5 @@
             </intent-filter>
         </activity>
     </application>
+
 </manifest>

ShareWithTitle/src/main/java/net/crystalyx/sharewithtitle/HttpThreadHandler.java

@@ -1,6 +1,8 @@
 package net.crystalyx.sharewithtitle;
 
 import org.jsoup.Jsoup;
+import org.jsoup.nodes.Document;
+import org.jsoup.nodes.Element;
 
 import java.io.IOException;
 import java.net.URL;
@@ -17,7 +19,25 @@ public class HttpThreadHandler implements Runnable {
     @Override
     public void run() {
         try {
-            title = Jsoup.connect(url.toString()).get().title();
+            Document doc = Jsoup.connect(url.toString()).get();
+            String titleMeta = doc.title();
+            Element descriptionMeta = doc.select("meta[name=description]").first();
+            Element titleElement = doc.select("meta[property=og:title]").first();
+            Element descriptionElement = doc.select("meta[property=og:description]").first();
+
+            if (titleElement != null) {
+                title = titleElement.attr("content");
+                if (descriptionElement != null) {
+                    title += "\n" + descriptionElement.attr("content");
+                } else if (descriptionMeta != null) {
+                    title += "\n" + descriptionMeta.attr("content");
+                }
+            } else {
+                title = titleMeta;
+                if (descriptionMeta != null) {
+                    title += "\n" + descriptionMeta.attr("content");
+                }
+            }
         } catch (IOException e) {
             errorMessage = e.getMessage();
         }

ShareWithTitle/src/main/java/net/crystalyx/sharewithtitle/MainActivity.java

@@ -5,7 +5,7 @@ import android.content.Intent;
 import android.os.Bundle;
 import android.widget.Toast;
 
-import java.net.MalformedURLException;
+import java.net.URI;
 import java.net.URL;
 
 public class MainActivity extends Activity {
@@ -25,16 +25,16 @@ public class MainActivity extends Activity {
     }
 
     private void handleUrl(String textUrl) {
-        URL url;
+        URL originalUrl;
 
         try {
-            url = new URL(textUrl);
-        } catch (MalformedURLException e) {
+            originalUrl = new URI(textUrl).toURL();
+        } catch (Exception e) {
             Toast.makeText(this, e.getMessage(), Toast.LENGTH_SHORT).show();
             return;
         }
 
-        HttpThreadHandler handler = new HttpThreadHandler(url);
+        HttpThreadHandler handler = new HttpThreadHandler(originalUrl);
         Thread job = new Thread(handler);
 
         job.start();
@@ -50,7 +50,7 @@ public class MainActivity extends Activity {
         if (title != null) {
             Intent sharingIntent = new Intent(Intent.ACTION_SEND);
             sharingIntent.setType("text/plain");
-            sharingIntent.putExtra(Intent.EXTRA_TEXT, title + "\n\n" + url);
+            sharingIntent.putExtra(Intent.EXTRA_TEXT, title + "\n\n" + originalUrl);
             startActivity(Intent.createChooser(sharingIntent, "Share via"));
         } else if (errorMessage != null) {
             Toast.makeText(this, errorMessage, Toast.LENGTH_SHORT).show();

build.gradle

@@ -4,7 +4,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath("com.android.tools.build:gradle:8.1.0")
+        classpath("com.android.tools.build:gradle:8.4.0")
     }
 }
 

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME

gradlew

@@ -83,7 +83,8 @@ done
 # This is normally unused
 # shellcheck disable=SC2034
 APP_BASE_NAME=${0##*/}
-APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
+# Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036)
+APP_HOME=$( cd "${APP_HOME:-./}" > /dev/null && pwd -P ) || exit
 
 # Use the maximum available, or set MAX_FD != -1 to use that value.
 MAX_FD=maximum
@@ -144,7 +145,7 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
     case $MAX_FD in #(
       max*)
         # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked.
-        # shellcheck disable=SC3045
+        # shellcheck disable=SC2039,SC3045
         MAX_FD=$( ulimit -H -n ) ||
             warn "Could not query maximum file descriptor limit"
     esac
@@ -152,7 +153,7 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
       '' | soft) :;; #(
       *)
         # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked.
-        # shellcheck disable=SC3045
+        # shellcheck disable=SC2039,SC3045
         ulimit -n "$MAX_FD" ||
             warn "Could not set maximum file descriptor limit to $MAX_FD"
     esac
@@ -201,11 +202,11 @@ fi
 # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
 DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
 
-# Collect all arguments for the java command;
-#   * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
-#     shell script including quotes and variable substitutions, so put them in
-#     double quotes to make sure that they get re-expanded; and
-#   * put everything else in single quotes, so that it's not re-expanded.
+# Collect all arguments for the java command:
+#   * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,
+#     and any embedded shellness will be escaped.
+#   * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be
+#     treated as '${Hostname}' itself on the command line.
 
 set -- \
         "-Dorg.gradle.appname=$APP_BASE_NAME" \

gradlew.bat

@@ -43,11 +43,11 @@ set JAVA_EXE=java.exe
 %JAVA_EXE% -version >NUL 2>&1
 if %ERRORLEVEL% equ 0 goto execute
 
-echo.
-echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
-echo.
-echo Please set the JAVA_HOME variable in your environment to match the
-echo location of your Java installation.
+echo. 1>&2
+echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2
+echo. 1>&2
+echo Please set the JAVA_HOME variable in your environment to match the 1>&2
+echo location of your Java installation. 1>&2
 
 goto fail
 
@@ -57,11 +57,11 @@ set JAVA_EXE=%JAVA_HOME%/bin/java.exe
 
 if exist "%JAVA_EXE%" goto execute
 
-echo.
-echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
-echo.
-echo Please set the JAVA_HOME variable in your environment to match the
-echo location of your Java installation.
+echo. 1>&2
+echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 1>&2
+echo. 1>&2
+echo Please set the JAVA_HOME variable in your environment to match the 1>&2
+echo location of your Java installation. 1>&2
 
 goto fail
 

local.properties

@@ -1,8 +0,0 @@
-## This file must *NOT* be checked into Version Control Systems,
-# as it contains information specific to your local configuration.
-#
-# Location of the SDK. This is only used by Gradle.
-# For customization when using a Version Control System, please read the
-# header note.
-#Sun Jul 30 19:06:21 CEST 2023
-sdk.dir=/mnt/Eternia/AndroidSdk