Xefir
/
repod
1
1
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Projects Releases 25 Wiki Activity

Cannot use Nextcloud Search with app enabled #57

New Issue
Closed
opened 2024-02-03 09:01:33 +00:00 by JonOfUs · 5 comments
JonOfUs commented 2024-02-03 09:01:33 +00:00
Copy Link

Hi there, very cool app you are building here.

System: Nextcloud-aio, Nextcloud 27.1.5, php 8.1

When the app is enabled, I cannot use the Nextcloud Search.

The error message I get is:
Declaration of OCA\RePod\Service\SearchProvider::getOrder(string $route, array $routeParameters): ?int must be compatible with OCP\Search\IProvider::getOrder(string $route, array $routeParameters): int at /var/www/html/custom_apps/repod/lib/Service/SearchProvider.php#32

So it's maybe only necessary to change the return type of getOrder() to int?

Hi there, very cool app you are building here. System: Nextcloud-aio, Nextcloud 27.1.5, php 8.1 When the app is enabled, I cannot use the Nextcloud Search. The error message I get is: `Declaration of OCA\RePod\Service\SearchProvider::getOrder(string $route, array $routeParameters): ?int must be compatible with OCP\Search\IProvider::getOrder(string $route, array $routeParameters): int at /var/www/html/custom_apps/repod/lib/Service/SearchProvider.php#32` So it's maybe only necessary to change the return type of `getOrder()` to `int`?
Xefir closed this issue 2024-02-03 09:18:42 +00:00
Xefir commented 2024-02-03 09:28:23 +00:00
Owner
Copy Link

Thank you for reporting this !

In Nextcloud 28, this function can return null, so I mistakly copied the definition.
The change you hint is indeed the way to fix the issue.
A new version has been deployed, you'll have it in a few minutes.

I would like to take this opportunity to thank you for your commit inside the gPodder Sync repository to include RePod in the list of compatible gPodder Sync app.
b4739dff02

Thank you for reporting this ! In Nextcloud 28, this function can return null, so I mistakly copied the definition. The change you hint is indeed the way to fix the issue. A new version has been deployed, you'll have it in a few minutes. I would like to take this opportunity to thank you for your commit inside the gPodder Sync repository to include RePod in the list of compatible gPodder Sync app. https://github.com/thrillfall/nextcloud-gpodder/commit/b4739dff02f76d6725c8a7468dba7ed123f7689c
JonOfUs commented 2024-02-03 10:11:26 +00:00
Author
Copy Link

Perfect, thanks for fixing this!

You're welcome :) always happy when I can sync podcasts with a new client - and that there now is a Nextcloud app is just great!

Btw: any chance you are at FOSDEM this weekend?

Perfect, thanks for fixing this! You're welcome :) always happy when I can sync podcasts with a new client - and that there now is a Nextcloud app is just great! Btw: any chance you are at FOSDEM this weekend?
Xefir commented 2024-02-03 10:14:11 +00:00
Owner
Copy Link

I didn't know that is this week !
I live in Nantes and Brussels is pretty far for me to be there now sadly.

Maybe next year ^^

I didn't know that is this week ! I live in Nantes and Brussels is pretty far for me to be there now sadly. Maybe next year ^^
JonOfUs commented 2024-02-03 10:29:36 +00:00
Author
Copy Link

Too bad, that would have been too nice. First time for me this year, but next year sounds good as well ^^

If you by any chance have time and are interested in even more podcast synchronization, I recommend taking a look at openpodcastapi.org. We are working on a protocol there that will hopefully replace Gpodder at some point. (Though the project is still in an early stage). And there even will be a lightning talk at FOSDEM about it: https://fosdem.org/2024/schedule/event/fosdem-2024-3390-introducing-the-open-podcast-api/

Too bad, that would have been too nice. First time for me this year, but next year sounds good as well ^^ If you by any chance have time and are interested in even more podcast synchronization, I recommend taking a look at [openpodcastapi.org](https://openpodcastapi.org). We are working on a protocol there that will hopefully replace Gpodder at some point. (Though the project is still in an early stage). And there even will be a lightning talk at FOSDEM about it: https://fosdem.org/2024/schedule/event/fosdem-2024-3390-introducing-the-open-podcast-api/
Xefir commented 2024-02-03 10:35:46 +00:00
Owner
Copy Link

Oh nice ! I will look forward to this new API but it won't change much for RePod since it relies at 100% to gPodder Sync.
But if gPodder Sync changes, I'll adapt my software as well ^^

Oh nice ! I will look forward to this new API but it won't change much for RePod since it relies at 100% to gPodder Sync. But if gPodder Sync changes, I'll adapt my software as well ^^
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
stats
2.2.1
2.2.0
2.1.0
2.0.0
1.5.9
1.5.8
1.5.7
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.0
1.2.1
1.2.0
1.1.2
1.1.1
1.1.0
1.0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Xefir/repod#57
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?