Xefir/repod
1
2
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 38 Wiki Activity

fix: 🐛 fix crash if no cache is configured
Some checks failed
repod / xml (push) Successful in 1m10s
Details
repod / php (push) Failing after 44s
Details
repod / nodejs (push) Successful in 1m25s
Details
repod / release (push) Has been skipped
Details

Browse Source
This commit is contained in:
Michel Roux 2024-06-14 19:32:26 +02:00
parent bc8db22fce
commit 42bfdb530b
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Controller/PodcastController.php
View File

@ -10,12 +10,14 @@ use OCA\RePod\AppInfo\Application;
use OCP\AppFramework\Controller; use OCP\AppFramework\Controller;
use OCP\AppFramework\Http\JSONResponse; use OCP\AppFramework\Http\JSONResponse;
use OCP\Http\Client\IClientService; use OCP\Http\Client\IClientService;
use OCP\ICacheFactory;
use OCP\IRequest; use OCP\IRequest;
class PodcastController extends Controller class PodcastController extends Controller
{ {
public function __construct( public function __construct(
IRequest $request, IRequest $request,
private ICacheFactory $cacheFactory,
private IClientService $clientService, private IClientService $clientService,
private PodcastDataReader $podcastDataReader private PodcastDataReader $podcastDataReader
) { ) {
@ -27,11 +29,13 @@ class PodcastController extends Controller
* @NoCSRFRequired * @NoCSRFRequired
*/ */
public function index(string $url): JSONResponse { public function index(string $url): JSONResponse {
if ($this->cacheFactory->isLocalCacheAvailable()) {
try { try {
$podcast = $this->podcastDataReader->tryGetCachedPodcastData($url); $podcast = $this->podcastDataReader->tryGetCachedPodcastData($url);
} catch (\Exception $e) { } catch (\Exception $e) {
$podcast = null; $podcast = null;
} }
}
if ($podcast) { if ($podcast) {
return new JSONResponse($podcast); return new JSONResponse($podcast);
@ -41,10 +45,12 @@ class PodcastController extends Controller
$feed = $client->get($url); $feed = $client->get($url);
$podcast = PodcastData::parseRssXml((string) $feed->getBody()); $podcast = PodcastData::parseRssXml((string) $feed->getBody());
if ($this->cacheFactory->isLocalCacheAvailable()) {
try { try {
$this->podcastDataReader->trySetCachedPodcastData($url, $podcast); $this->podcastDataReader->trySetCachedPodcastData($url, $podcast);
} catch (\Exception $e) { } catch (\Exception $e) {
} }
}
return new JSONResponse($podcast, $feed->getStatusCode()); return new JSONResponse($podcast, $feed->getStatusCode());
} }