From 37d264d717c5f5dd145f94114af4b5d7c4449297 Mon Sep 17 00:00:00 2001
From: Michel Roux <xefir@crystalyx.net>
Date: Wed, 17 Jan 2024 22:38:47 +0100
Subject: [PATCH] refacto: simplify tops wordings

---
 appinfo/routes.php                            |  4 +--
 ...plistController.php => TopsController.php} |  2 +-
 src/components/Atoms/AppContent.vue           |  4 +--
 src/components/Atoms/AppNavigation.vue        |  4 +--
 src/components/Discover/Tops.vue              | 27 +++++++++----------
 5 files changed, 19 insertions(+), 22 deletions(-)
 rename lib/Controller/{ToplistController.php => TopsController.php} (93%)

diff --git a/appinfo/routes.php b/appinfo/routes.php
index a7fd5fc..daf2f30 100644
--- a/appinfo/routes.php
+++ b/appinfo/routes.php
@@ -17,7 +17,7 @@ return [
 		['name' => 'episodes#list', 'url' => '/episodes/list', 'verb' => 'GET'],
 		['name' => 'podcast#index', 'url' => '/podcast', 'verb' => 'GET'],
 		['name' => 'search#index', 'url' => '/search', 'verb' => 'GET'],
-		['name' => 'toplist#hot', 'url' => '/toplist/hot', 'verb' => 'GET'],
-		['name' => 'toplist#new', 'url' => '/toplist/new', 'verb' => 'GET'],
+		['name' => 'tops#hot', 'url' => '/tops/hot', 'verb' => 'GET'],
+		['name' => 'tops#new', 'url' => '/tops/new', 'verb' => 'GET'],
 	],
 ];
diff --git a/lib/Controller/ToplistController.php b/lib/Controller/TopsController.php
similarity index 93%
rename from lib/Controller/ToplistController.php
rename to lib/Controller/TopsController.php
index 28bef13..6c5285d 100644
--- a/lib/Controller/ToplistController.php
+++ b/lib/Controller/TopsController.php
@@ -10,7 +10,7 @@ use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\JSONResponse;
 use OCP\IRequest;
 
-class ToplistController extends Controller
+class TopsController extends Controller
 {
 	public function __construct(
 		IRequest $request,
diff --git a/src/components/Atoms/AppContent.vue b/src/components/Atoms/AppContent.vue
index 263e73a..49200bf 100644
--- a/src/components/Atoms/AppContent.vue
+++ b/src/components/Atoms/AppContent.vue
@@ -1,5 +1,5 @@
 <template>
-	<NcAppContent :class="episode ? 'margin' : ''">
+	<NcAppContent :class="episode ? 'padding' : ''">
 		<slot />
 	</NcAppContent>
 </template>
@@ -21,7 +21,7 @@ export default {
 </script>
 
 <style scoped>
-	.margin {
+	.padding {
 		padding-bottom: 6rem;
 	}
 </style>
diff --git a/src/components/Atoms/AppNavigation.vue b/src/components/Atoms/AppNavigation.vue
index 2f3a2db..7369e44 100644
--- a/src/components/Atoms/AppNavigation.vue
+++ b/src/components/Atoms/AppNavigation.vue
@@ -1,5 +1,5 @@
 <template>
-	<NcAppNavigation :class="episode ? 'margin' : ''">
+	<NcAppNavigation :class="episode ? 'padding' : ''">
 		<slot />
 		<template #list>
 			<slot name="list" />
@@ -27,7 +27,7 @@ export default {
 </script>
 
 <style scoped>
-	.margin {
+	.padding {
 		padding-bottom: 6rem;
 	}
 </style>
diff --git a/src/components/Discover/Tops.vue b/src/components/Discover/Tops.vue
index 3661e05..40b9652 100644
--- a/src/components/Discover/Tops.vue
+++ b/src/components/Discover/Tops.vue
@@ -3,7 +3,7 @@
 		<h2>{{ title }}</h2>
 		<Loading v-if="loading" />
 		<ul v-if="!loading">
-			<li v-for="top in items" :key="top.link">
+			<li v-for="top in tops" :key="top.link">
 				<router-link :to="toUrl(top.link)">
 					<img :src="top.imageUrl" :title="top.author">
 				</router-link>
@@ -32,8 +32,8 @@ export default {
 	},
 	data() {
 		return {
-			items: [],
 			loading: true,
+			tops: [],
 		}
 	},
 	computed: {
@@ -49,22 +49,19 @@ export default {
 		},
 	},
 	async mounted() {
-		this.loadList()
+		try {
+			this.loading = true
+			const tops = await axios.get(generateUrl(`/apps/repod/tops/${this.type}`))
+			this.tops = tops.data
+		} catch (e) {
+			console.error(e)
+			showError(t('repod', 'Could not fetch tops'))
+		} finally {
+			this.loading = false
+		}
 	},
 	methods: {
 		toUrl,
-		async loadList() {
-			try {
-				this.loading = true
-				const toplist = await axios.get(generateUrl(`/apps/repod/toplist/${this.type}`))
-				this.items = toplist.data
-			} catch (e) {
-				console.error(e)
-				showError(t('repod', 'Could not fetch tops'))
-			} finally {
-				this.loading = false
-			}
-		},
 	},
 }
 </script>