From 1eb8b35501d56d038f6428422bb25db94ffbbac8 Mon Sep 17 00:00:00 2001
From: Michel Roux <xefir@crystalyx.net>
Date: Mon, 2 Sep 2024 15:54:21 +0200
Subject: [PATCH] refactor: :art: cleanup some old css class

---
 src/components/Feed/Episode.vue                   |  4 ++--
 .../Feed/{Favorites.vue => Favorite.vue}          |  2 +-
 src/components/Player/Timer.vue                   |  4 ++--
 src/components/Player/Volume.vue                  | 15 ++++++++-------
 src/views/Feed.vue                                | 11 +----------
 src/views/GPodder.vue                             |  2 +-
 src/views/Home.vue                                |  6 +++---
 7 files changed, 18 insertions(+), 26 deletions(-)
 rename src/components/Feed/{Favorites.vue => Favorite.vue} (99%)

diff --git a/src/components/Feed/Episode.vue b/src/components/Feed/Episode.vue
index bfa6a15..f6852f1 100644
--- a/src/components/Feed/Episode.vue
+++ b/src/components/Feed/Episode.vue
@@ -81,8 +81,8 @@
 				class="progress"
 				:value="(episode.action.position * 100) / episode.action.total" />
 		</template>
-		<template v-if="!oneLine" #subname>
-			{{ episode.duration }}
+		<template #subname>
+			<span v-if="!oneLine">{{ episode.duration }}</span>
 		</template>
 	</NcListItem>
 </template>
diff --git a/src/components/Feed/Favorites.vue b/src/components/Feed/Favorite.vue
similarity index 99%
rename from src/components/Feed/Favorites.vue
rename to src/components/Feed/Favorite.vue
index faa57e5..80c9623 100644
--- a/src/components/Feed/Favorites.vue
+++ b/src/components/Feed/Favorite.vue
@@ -35,7 +35,7 @@ import { showError } from '../../utils/toast.js'
 import { useSubscriptions } from '../../store/subscriptions.js'
 
 export default {
-	name: 'Favorites',
+	name: 'Favorite',
 	components: {
 		Episode,
 		Loading,
diff --git a/src/components/Player/Timer.vue b/src/components/Player/Timer.vue
index ebce2a6..3478db5 100644
--- a/src/components/Player/Timer.vue
+++ b/src/components/Player/Timer.vue
@@ -1,5 +1,5 @@
 <template>
-	<div>
+	<div class="root">
 		<span>{{ formatTimer(new Date(currentTime * 1000)) }}</span>
 		<span>/</span>
 		<span>{{ formatTimer(new Date(duration * 1000)) }}</span>
@@ -23,7 +23,7 @@ export default {
 </script>
 
 <style scoped>
-div {
+.root {
 	align-items: center;
 	display: flex;
 	gap: 5px;
diff --git a/src/components/Player/Volume.vue b/src/components/Player/Volume.vue
index cb7ef90..cadbc00 100644
--- a/src/components/Player/Volume.vue
+++ b/src/components/Player/Volume.vue
@@ -1,5 +1,5 @@
 <template>
-	<div>
+	<div class="root">
 		<VolumeHighIcon
 			v-if="volume > 0.7"
 			class="pointer"
@@ -21,6 +21,7 @@
 			:size="30"
 			@click="setVolume(volumeMuted)" />
 		<input
+			class="volume"
 			max="1"
 			min="0"
 			step="0.1"
@@ -63,19 +64,19 @@ export default {
 </script>
 
 <style scoped>
-div {
+.pointer {
+	cursor: pointer;
+}
+
+.root {
 	align-items: center;
 	display: flex;
 	gap: 5px;
 	justify-content: flex-end;
 }
 
-input {
+.volume {
 	transform: rotate(270deg);
 	width: 4rem;
 }
-
-.pointer {
-	cursor: pointer;
-}
 </style>
diff --git a/src/views/Feed.vue b/src/views/Feed.vue
index f1f9b61..c0a3f4b 100644
--- a/src/views/Feed.vue
+++ b/src/views/Feed.vue
@@ -1,10 +1,7 @@
 <template>
 	<AppContent>
 		<Loading v-if="loading" />
-		<EmptyContent
-			v-if="failed"
-			class="error"
-			:name="t('repod', 'Error loading feed')">
+		<EmptyContent v-if="failed" :name="t('repod', 'Error loading feed')">
 			<template #icon>
 				<Alert />
 			</template>
@@ -66,9 +63,3 @@ export default {
 	},
 }
 </script>
-
-<style scoped>
-.error {
-	margin: 2rem;
-}
-</style>
diff --git a/src/views/GPodder.vue b/src/views/GPodder.vue
index 3fca7dc..adf0f25 100644
--- a/src/views/GPodder.vue
+++ b/src/views/GPodder.vue
@@ -1,6 +1,6 @@
 <template>
 	<AppContent>
-		<EmptyContent class="empty" :name="t('repod', 'Missing required app')">
+		<EmptyContent :name="t('repod', 'Missing required app')">
 			<template #action>
 				<NcButton :href="gPodderSyncUrl">
 					{{ t('repod', 'Install GPodder Sync') }}
diff --git a/src/views/Home.vue b/src/views/Home.vue
index 031030a..2b519ec 100644
--- a/src/views/Home.vue
+++ b/src/views/Home.vue
@@ -12,7 +12,7 @@
 		</EmptyContent>
 		<ul v-if="getFavorites.length">
 			<li v-for="url in getFavorites.map((fav) => fav.url)" :key="url">
-				<Favorites :url="url" />
+				<Favorite :url="url" />
 			</li>
 		</ul>
 	</AppContent>
@@ -21,7 +21,7 @@
 <script>
 import AppContent from '../components/Atoms/AppContent.vue'
 import EmptyContent from '../components/Atoms/EmptyContent.vue'
-import Favorites from '../components/Feed/Favorites.vue'
+import Favorite from '../components/Feed/Favorite.vue'
 import StarOffIcon from 'vue-material-design-icons/StarOff.vue'
 import { mapState } from 'pinia'
 import { useSubscriptions } from '../store/subscriptions.js'
@@ -31,7 +31,7 @@ export default {
 	components: {
 		AppContent,
 		EmptyContent,
-		Favorites,
+		Favorite,
 		StarOffIcon,
 	},
 	computed: {