Xefir/pilotwings
1
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: 🐛 prevent taking over container from admin
All checks were successful
pilotwings / python (push) Successful in 1m46s
Details
pilotwings / node (push) Successful in 1m15s
Details
pilotwings / docker (push) Successful in 2m20s
Details

Browse Source
This commit is contained in:
Michel Roux 2024-11-06 22:20:30 +01:00
parent b1d308a977
commit 16e4120b24
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
backend/pilotwings.py
View File

@ -72,6 +72,7 @@ def create_or_update_container(
request_body: ContainerRequest, request_body: ContainerRequest,
credentials: Annotated[HTTPBasicCredentials, Depends(security)], credentials: Annotated[HTTPBasicCredentials, Depends(security)],
) -> SerializedContainer: ) -> SerializedContainer:
owner = None
networks = client.networks.list(names=["pilotwings"]) networks = client.networks.list(names=["pilotwings"])
if not networks: if not networks:
@ -80,25 +81,25 @@ def create_or_update_container(
client.images.pull(request_body.image) client.images.pull(request_body.image)
try: try:
container = select_container(container_name, credentials)
owner = container.labels.get("owner")
delete_container(container_name, credentials) delete_container(container_name, credentials)
except HTTPException: except HTTPException:
pass pass
container = serialize_container( container = client.containers.run(
client.containers.run( request_body.image,
request_body.image, detach=True,
detach=True, environment=request_body.environment,
environment=request_body.environment, labels={"engine": "pilotwings", "owner": owner or credentials.username},
labels={"engine": "pilotwings", "owner": credentials.username}, name=container_name,
name=container_name, network="pilotwings",
network="pilotwings", restart_policy={"Name": "always"},
restart_policy={"Name": "always"},
)
) )
client.images.prune({"dangling": True}) client.images.prune({"dangling": True})
return container return serialize_container(container)
@app.post("/api/container/{container_name}/pull") @app.post("/api/container/{container_name}/pull")